Skip to content

Commit f517dfe

Browse files
authored
Merge pull request #305 from alltilla/dbdl-support-no-tty
dbld: do not try to get pseudo terminal when TTY is not available
2 parents fcbb8c6 + 8a739a4 commit f517dfe

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

dbld/rules

+4-3
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ GIT_RELEASE_TAG=axosyslog-$(VERSION)
5454
CONFIGURE_OPTS=--enable-debug --enable-manpages --with-python=3 --prefix=/install $(CONFIGURE_ADD)
5555
DBLD_RULES=$(MAKE) --no-print-directory -f $(DBLD_DIR)/rules
5656

57-
DOCKER_SHELL=$(DOCKER) run $(DOCKER_RUN_ARGS) --rm -ti ${CONTAINER_REGISTRY}/axosyslog-dbld-$* /dbld/shell $(if $(SHELL_COMMAND),"$(SHELL_COMMAND)",bash)
57+
DOCKER_INTERACTIVE=$(shell if tty -s; then echo "-ti"; else echo "-i"; fi)
58+
DOCKER_SHELL=$(DOCKER) run $(DOCKER_RUN_ARGS) --rm $(DOCKER_INTERACTIVE) ${CONTAINER_REGISTRY}/axosyslog-dbld-$* /dbld/shell $(if $(SHELL_COMMAND),"$(SHELL_COMMAND)",bash)
5859

5960
-include $(if $(RULES_CONF),$(RULES_CONF),$(DBLD_DIR)/rules.conf)
6061

@@ -203,7 +204,7 @@ clean:
203204
run: run-$(DEFAULT_IMAGE)
204205
run: RUN_COMMAND=echo Specify RUN_COMMAND to do something sensible here
205206
run-%: setup
206-
$(DOCKER) run $(DOCKER_RUN_ARGS) --rm -ti ${CONTAINER_REGISTRY}/axosyslog-dbld-$* bash -c "$(RUN_COMMAND)"
207+
$(DOCKER) run $(DOCKER_RUN_ARGS) --rm $(DOCKER_INTERACTIVE) ${CONTAINER_REGISTRY}/axosyslog-dbld-$* bash -c "$(RUN_COMMAND)"
207208

208209
shell: shell-$(DEFAULT_IMAGE)
209210
shell-%: setup
@@ -258,7 +259,7 @@ exec: exec-$(DEFAULT_IMAGE)
258259
exec: EXEC_COMMAND=echo Specify EXEC_COMMAND to do something sensible here
259260
exec-%: setup
260261
@container=`$(DOCKER) ps | grep axosyslog-dbld-$* | head -1 | cut -d ' ' -f1`; \
261-
$(DOCKER) exec -ti $$container $(EXEC_COMMAND)
262+
$(DOCKER) exec $(DOCKER_INTERACTIVE) $$container $(EXEC_COMMAND)
262263

263264
login: login-$(DEFAULT_IMAGE)
264265
login-%: EXEC_COMMAND=sudo -u $(shell whoami) /dbld/shell

0 commit comments

Comments
 (0)