Merge pull request #462 from bshifter/fx-fix-pubsub

Fix filterx/pubsub message empty attributes

Author: alltilla

modules/grpc/pubsub/filterx/object-pubsub-message.cpp

@@ -101,10 +101,6 @@ Message::set_attribute(const std::string &key, const std::string &value)
         {
           throw std::invalid_argument("Key cannot be empty");
         }
-      if (value.empty())
-        {
-          throw std::invalid_argument("Value cannot be empty");
-        }
       auto attributes = message.mutable_attributes();
       if (attributes)
         {

tests/light/functional_tests/filterx/test_filterx.py

@@ -2634,13 +2634,15 @@ def test_pubsub_message(config, syslog_ng):
         config, r"""
     $MSG = json();
     $MSG.msg = pubsub_message("my pubsub message", {"foo":"bar"});
+    $MSG.empty = pubsub_message("empty attribute value", {"empty":""});
     """,
     )
     syslog_ng.start(config)
 
     assert file_true.get_stats()["processed"] == 1
     assert "processed" not in file_false.get_stats()
     exp = (
-        r"""{"msg":{"data":"my pubsub message","attributes":{"foo":"bar"}}}""" + "\n"
+        r"""{"msg":{"data":"my pubsub message","attributes":{"foo":"bar"}},"""
+        """"empty":{"data":"empty attribute value","attributes":{"empty":""}}}""" + "\n"
     )
     assert file_true.read_log() == exp