Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce builder copies using a managed reference #995

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

mtdowling
Copy link
Member

This commit reduces the number of copies builders need to make when
building up immutable objects.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mtdowling mtdowling requested a review from a team as a code owner November 29, 2021 07:22
@mtdowling mtdowling force-pushed the reduce-builder-copies branch from 766027c to 7c1f63b Compare November 29, 2021 07:49
@mtdowling mtdowling force-pushed the reduce-builder-copies branch from 7c1f63b to 0953b33 Compare November 29, 2021 17:47
@mtdowling
Copy link
Member Author

Relevant benchmarks:

Before:

Benchmark                                  Mode  Cnt   Score   Error  Units
Selectors.loadsIdlModelWithoutValidation   avgt    3  57.376 ± 5.336  us/op
Selectors.loadsJsonModelWithoutValidation  avgt    3  73.979 ± 9.156  us/op

After:

Benchmark                                  Mode  Cnt   Score    Error  Units
Selectors.loadsIdlModelWithoutValidation   avgt    3  50.852 ± 11.004  us/op
Selectors.loadsJsonModelWithoutValidation  avgt    3  61.740 ±  6.504  us/op

This commit reduces the number of copies builders need to make when
building up immutable objects.
@mtdowling mtdowling force-pushed the reduce-builder-copies branch from f8fb6b3 to 41774d6 Compare November 29, 2021 23:00
@mtdowling mtdowling merged commit c740fdb into main Nov 29, 2021
@mtdowling mtdowling deleted the reduce-builder-copies branch January 7, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants