Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate known media types in protocol tests #822

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

mtdowling
Copy link
Member

This commit updates protocol test validators to ensure that known media
types for XML and JSON contain valid content.

Closes #821

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the valid-xml.smithy file is empty.

This commit updates protocol test validators to ensure that known media
types for XML and JSON contain valid content.

Closes #821
@mtdowling mtdowling force-pushed the validate-protocol-test-bodies branch from 0ffb31e to dee3a0b Compare June 9, 2021 01:01
@mtdowling mtdowling requested a review from kstich June 9, 2021 01:01
@mtdowling mtdowling merged commit 0678613 into main Jun 9, 2021
@mtdowling mtdowling deleted the validate-protocol-test-bodies branch June 15, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ec2Query protocol codegen tests
2 participants