Add methods to get shapes by type and trait #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested review from
JordonPhillips,
kstich and
srchase
as code owners
mtdowling
force-pushed
the
add-typed-model-methods
branch
2 times, most recently
from
720f4f3 to
f9e5c29
Compare
JordonPhillips
approved these changes
May 18, 2021
Comment on lines
+231
to
+233
| public Set<BigDecimalShape> getBigDecimalShapesWithTrait(Class<? extends Trait> trait) { | ||
| return new ShapeTypeFilteredSet<>(getShapesWithTrait(trait), BigDecimalShape.class); | ||
| } |
There was a problem hiding this comment.
I'm not really a huge fan of having methods for each shape type, but this would head-off fat-fingering and it's a bit easier to understand for people less experienced with java.
There was a problem hiding this comment.
This is also much more usable than having two Class params generally.
smithy-model/src/main/java/software/amazon/smithy/model/ShapeTypeFilteredSet.java
Show resolved
Hide resolved
kstich
reviewed
May 18, 2021
smithy-model/src/main/java/software/amazon/smithy/model/ShapeTypeFilteredSet.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/Model.java
Outdated
Show resolved
Hide resolved
Comment on lines
+231
to
+233
| public Set<BigDecimalShape> getBigDecimalShapesWithTrait(Class<? extends Trait> trait) { | ||
| return new ShapeTypeFilteredSet<>(getShapesWithTrait(trait), BigDecimalShape.class); | ||
| } |
There was a problem hiding this comment.
This is also much more usable than having two Class params generally.
Model now contains methods for every shape type to get a Set of shapes or that type or a set of shapes of a type that have a specific trait. These methods are simpler to use than `shapes(Class)` and `toSet(Class)`, and they hopefully encourage the use of the caches that Model uses. These methods also eliminated a lot of boilerplat that getShapesWithTrait previously required when only shapes of a certain type were needed.
mtdowling
force-pushed
the
add-typed-model-methods
branch
from
f9e5c29 to
9126135
Compare
kstich
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model now contains methods for every shape type to get a Set of shapes
or that type or a set of shapes of a type that have a specific trait.
These methods are simpler to use than
shapes(Class)andtoSet(Class), and they hopefully encourage the use of the caches thatModel uses. These methods also eliminated a lot of boilerplat that
getShapesWithTrait previously required when only shapes of a certain
type were needed.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.