Warn against potentially risky hostPrefixes #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested review from
kstich,
mtdowling and
srchase
as code owners
JordonPhillips
commented
Apr 23, 2021
...rc/main/java/software/amazon/smithy/model/validation/validators/HostLabelTraitValidator.java
Outdated
Show resolved
Hide resolved
|
Thanks for addressing the issue. The hostLabel documentation |
JordonPhillips
force-pushed
the
warn-host-prefix
branch
from
35744d6 to
b4fdf6d
Compare
|
Whoops, that was actually a bug - the other example on the page and the json version of that same example all end in periods |
srchase
approved these changes
Apr 26, 2021
This updates the documentation and adds a warning for the case where
a `hostPrefix` contains a host label but does not end in a period.
This is potentially risky since it could change the domain to
something that the modeler doesn't control. For example, a host
label of `{foo}` combined with a configured endpoint `example.com`
could result in a resolved host of `mistakeexample.com` when the
modeler wanted it to resolve to `mistake.example.com`. If the modeler
doesn't own EVERY domain suffixed by the configured endpoint then
it is possible that customer data will be exposed.
JordonPhillips
force-pushed
the
warn-host-prefix
branch
from
b4fdf6d to
f983869
Compare
kstich
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation and adds a warning for the case where a
hostPrefixcontains a host label but does not end in a period. This is potentially risky since it could change the domain to something that the modeler doesn't control. For example, a host label of{foo}combined with a configured endpointexample.comcould result in a resolved host ofmistakeexample.comwhen the modeler wanted it to resolve tomistake.example.com. If the modeler doesn't own EVERY domain suffixed by the configured endpoint then it is possible that customer data will be exposed.Resolves #778
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.