Cleanup HTTP trait spec #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clarifications and examples to several HTTP traits, most importantly to the httpLabel and httpQuery traits. These traits were updated so that they require percent-encoding all reserved characters defined in RFC3986. This is the behavior in use today by all AWS SDKs and protocol tests, and if we ever need to support reserved characters in query strings or labels, additional configuration or traits can be added.
JordonPhillips
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clarifications and examples to several HTTP traits, most importantly
to the httpLabel and httpQuery traits. These traits were updated so that
they require percent-encoding all reserved characters defined in
RFC3986. This is the behavior in use today by all AWS SDKs and protocol
tests, and if we ever need to support reserved characters in query strings
or labels, additional configuration or traits can be added.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.