More windows fixes #577
Merged
More windows fixes #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normalization being done for URLs to ensure they de-dupe with normal files was overzealous and stripped off a leading "jar:". This causes issues when later trying to load JAR files in Windows because the path gets mess up with a leading backslash and no indicator it needs to load from a JAR. By no longer stripping off "jar:" but still normalizing "file:", the original intent is kept but this now works in Windows.
kstich
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds various fixes to Smithy and tests so that they now work on Windows. We'll need to configure our tests to automatically run on Windows to ensure there are no regressions here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.