Don't raise validation erros from renaming #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Jul 29, 2020
smithy-model/src/main/java/software/amazon/smithy/model/transform/RenameShapes.java
Show resolved
Hide resolved
None of the other transformers raise validation errors when they produce a model in an invalid state, so the rename transformer shouldn't either. With this change a tool could attempt to resolve any issue before the model is actually used.
This disables validation in the default model assembler for the rename transformer.
JordonPhillips
force-pushed
the
rename-without-validation
branch
from
a2243c9 to
476b123
Compare
mtdowling
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the other transformers raise validation errors when
they produce a model in an invalid state, so the rename transformer
shouldn't either. With this change a tool could attempt to resolve
any issue before the model is actually used.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.