Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade SdkServiceIdValidator to DANGER #1772

Merged
merged 1 commit into from
May 16, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented May 16, 2023

This PR downgrades the validation events emitted by the SdkServiceIdValidator from ERROR to DANGER, allowing for them to be suppressible.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner May 16, 2023 18:26
@srchase srchase merged commit 06cc4f5 into smithy-lang:main May 16, 2023
@srchase srchase deleted the sdk-id-validator-danger branch May 16, 2023 18:58
syall pushed a commit to Xtansia/smithy that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants