Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --flatten flag to the AST command #1723

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

sugmanue
Copy link
Contributor

@sugmanue sugmanue commented Apr 5, 2023

Description of changes:

Adds a new --flatten flag to the AST command that will flatten and remove the mixins from the model. This helps a lot with understanding how the model looks like without any mixins.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sugmanue sugmanue requested a review from a team as a code owner April 5, 2023 23:05
Copy link
Member

@mtdowling mtdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test?

@sugmanue
Copy link
Contributor Author

sugmanue commented Apr 6, 2023

Can you add an integration test?

Done, added tests to verify that no flatten is done without the option and that the flatten is done with it.

@sugmanue sugmanue merged commit e9f2af8 into smithy-lang:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants