Remove presence tracking from default values #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the recommendation for using presence tracking default values, and instead advocates for serializing default values. This ensures that whatever an implementation thinks the default value is currently is unambiguoulsy honored by anything that deserializers the message later at any point in time, including if the default value for that member has since changed in the model. This also removes the large amount of complexity that presence brings with it. While this does make it harder for a default value to change, changing defaults is meant to be very rare anyways. So the tradeoff here seems worth it given changing defaults was and continues to be so strongly discouraged.
JordonPhillips
approved these changes
Mar 16, 2023
sugmanue
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the recommendation for using presence tracking default values, and instead advocates for serializing default values. This ensures that whatever an implementation thinks the default value is currently is unambiguoulsy honored by anything that deserializes the message later at any point in time, including if the default value for that member has since changed in the model. This also removes the large amount of complexity that presence tracking brings with it. While this does make it harder for a default value to change in clients, changing defaults is meant to be very rare anyways. So the tradeoff here seems worth it given changing defaults was and continues to be so strongly discouraged.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.