Allow using path expressions in paginator outputs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Sep 4, 2019
...rc/main/java/software/amazon/smithy/model/validation/validators/PaginatedTraitValidator.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/traits/PaginatedTraitTest.java
Show resolved
Hide resolved
mtdowling
reviewed
Sep 4, 2019
...est/resources/software/amazon/smithy/model/errorfiles/validators/paginated-trait-test.errors
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
pagination
branch
from
de95ab1 to
d382b43
Compare
mtdowling
approved these changes
Sep 4, 2019
| @@ -59,6 +62,7 @@ | |||
| private static final Set<ShapeType> ITEM_SHAPES = SetUtils.of(ShapeType.LIST, ShapeType.MAP); | |||
| private static final Set<ShapeType> PAGE_SHAPES = SetUtils.of(ShapeType.INTEGER); | |||
| private static final Set<ShapeType> STRING_SET = SetUtils.of(ShapeType.STRING); | |||
| private static final java.util.regex.Pattern PATH_PATTERN = Pattern.compile("\\."); | |||
There was a problem hiding this comment.
Whoops - can you remove this fully-qualified reference?
| ShapeIndex index, OperationIndex opIndex, OperationShape operation, PaginatedTrait trait | ||
| ) { | ||
| // Split up the path expression into a list of member names | ||
| Optional<List<String>> memberNames = getMemberPath(opIndex, operation, trait) |
There was a problem hiding this comment.
Minor: this could be simplified to:
List<String> memberNames = getMemberPath(opIndex, operation, trait)
.map(value -> Arrays.asList(value.split("\\.")))
.orElse(Collections.emptyList());
kstich
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This allows the use of path expressions in paginator outputs. This enables
customers to have result wrapper shapes, which is a common pattern in XML
protocols.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.