Simplify ShapeId caching #1411
Merged
Simplify ShapeId caching #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation could cause a recursive update error when a shape ID is purged from the cache because it attempted to remove an element from the ConcurrentHashMap inside of a computeIfAbsent call. This updated approach is simpler and instead separates prelude shape IDs into a ConcurrentHashMap that just stops caching after 500 entries are in the cache (which does more than cover the shapes currently in the prelude), and uses a synchronized LinkedHashMap to function as an LRU cache for all other shape IDs. The performance of this approach vs what we had previously is essentially the same.
mtdowling
force-pushed
the
fix-shapeid-cache
branch
from
8f0b861 to
f0bc7a5
Compare
sugmanue
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation could cause a recursive update error when a shape ID is purged from the cache because it attempted to remove an element from the ConcurrentHashMap inside of a computeIfAbsent call. This updated approach is simpler and instead separates prelude shape IDs into a ConcurrentHashMap that just stops caching after 500 entries are in the cache (which does more than cover the shapes currently in the prelude), and uses a synchronized LinkedHashMap to function as an LRU cache for all other shape IDs. The performance of this approach vs what we had previously is essentially the same.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.