Rewrite a lot of the CLI for easier testing #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves most CLI output to stderr, updates Colors to become Color, makes Color return formatted text rather than print, adds a CliPrinter interface that manages printing to stdout/stderr, and allows commands to use per/command printers to make testing easier. This change is still backwards compatible with the existing static setters that are used by the smithy-gradle-plugin. Addresses #1195
mtdowling
changed the title
mtdowling
force-pushed
the
refactor-cli-printing
branch
2 times, most recently
from
e336ecf to
4f81d24
Compare
mtdowling
force-pushed
the
refactor-cli-printing
branch
2 times, most recently
from
2b3807d to
9140628
Compare
mtdowling
force-pushed
the
refactor-cli-printing
branch
8 times, most recently
from
059cd3f to
42e5085
Compare
This commit rewrites much of the CLI to make it easier to test, provide more control over colors and styling, more control over command argument parsing, and attempts to better handle logging. Followups to this commit are to add support for --silent and potentially add support for controlling the number of threads used by the CLI by passing an executor through to everything.
mtdowling
force-pushed
the
refactor-cli-printing
branch
from
42e5085 to
f8e5bf5
Compare
smithy-cli/src/main/java/software/amazon/smithy/cli/StandardOptions.java
Show resolved
Hide resolved
This commit updates commands so that there is now a HelpPrinter abstraction used to manage printing help.
JordonPhillips
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves most CLI output to stderr, updates Colors to become
Color, makes Color return formatted text rather than print, adds a
CliPrinter interface that manages printing to stdout/stderr, and allows
commands to use per/command printers to make testing easier. This change
is still backwards compatible with the existing static setters that are
used by the smithy-gradle-plugin.
This commit also adds support for
--quietto all commands. This option silences all output except for errors and SEVERE log messages.Closes #1195
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.