Make SmithyIntegrations available from CodegenContext #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, only made it available from CreateContextDirective, so subclasses CodegenContext can access it. But it likely can be made part of parent CodegenContext interface.
gosar
changed the title
mtdowling
approved these changes
Jun 17, 2022
mtdowling
approved these changes
Jun 24, 2022
gosar
commented
Jun 24, 2022
| */ | ||
| public interface DirectedCodegen<C extends CodegenContext<S, ?>, S> { | ||
| public interface DirectedCodegen<C extends CodegenContext<S, ?, I>, S, I extends SmithyIntegration<S, ?, ?>> { |
There was a problem hiding this comment.
hmm, this can be I extends SmithyIntegration<S, ?, C>> since C is defined here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 commits.
The 1st commit, only made
SmithyIntegrations available from CreateContextDirective, so subclassesof CodegenContext can access it. But it likely can be made part of parent CodegenContext interface.
The 2nd commit, made it part of CodegenContext interface.
This requires another generic parameter to be added in multiple places.Avoided adding generic parameter to CodegenContext by defining the method asList<? extends SmithyIntegration<S, W, ?>> integrations();where subclasses can return more specificList<MyIntegration> integrations();By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.