Create new classes for writing and delegation #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested changes
Mar 15, 2022
smithy-codegen-core/src/main/java/software/amazon/smithy/codegen/core/WriterDelegator.java
Outdated
Show resolved
Hide resolved
smithy-codegen-core/src/test/java/software/amazon/smithy/codegen/core/MySimpleWriter.java
Outdated
Show resolved
Hide resolved
The previous classes for CodegenWriter, CodegenWriterDelegator, and ImportContainer were in the `@SmithyUnstableApi` package, `writer`. This package relied on the now defunct `CodeWriter` (replaced by `AbstractCodeWriter`). After learning more about how these abstractions are being used and now that they need to be updated to use `AbstractCodeWriter` instead, CodegenWriter has been obsoleted by SymbolWriter, ImportContainer is obsoleted by a class of the same name in the parent package, and CodegenWriterDelegator by WriterDelegator.
mtdowling
force-pushed
the
codegen-symbols
branch
from
d49512c to
4f6a364
Compare
JordonPhillips
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous classes for CodegenWriter, CodegenWriterDelegator, and
ImportContainer were in the
@SmithyUnstableApipackage,writer. Thispackage relied on the now defunct
CodeWriter(replaced byAbstractCodeWriter). After learning more about how these abstractionsare being used and now that they need to be updated to use
AbstractCodeWriterinstead, CodegenWriter has been obsoleted bySymbolWriter, ImportContainer is obsoleted by a class of the same name
in the parent package, and CodegenWriterDelegator by WriterDelegator.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.