Reduce HttpBindingsMissing severity for non-REST services #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Jan 8, 2022
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| // Only emit ERROR events if any of the protocols for the service support HTTP traits | ||
| private Severity determineSeverity(ServiceShape service, Model model) { | ||
| if (service.getAllTraits().values() |
There was a problem hiding this comment.
HttpBindingsMissing emits an ERROR event for all services that have inconsistently @http traited operations, but not all protocols support @http. This change inspects the list of supported traits for every protocol trait applied to the service, and if none of them support the http trait, then HttpBindingsMissing is emitted at WARNING, instead of ERROR.
adamthom-amzn
force-pushed
the
http-bindings-missing-severity
branch
from
c2005f3 to
291ea26
Compare
mtdowling
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
HttpBindingsMissing emits an ERROR event for all services that have
inconsistently @http traited operations, but not all protocols support @http.
This change inspects the list of supported traits for every protocol trait
applied to the service, and if none of them support the http trait, then
HttpBindingsMissing is emitted at WARNING, instead of ERROR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.