docs(s2n-quic): add a comment about docke+GSO #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Feb 26, 2025
| ``` | ||
|
|
||
| In the case of running tests in broken GSO environments, setting `S2N_QUIC_PLATFORM_FEATURES_OVERRIDE=""` as an environment variable will disable the feature. |
There was a problem hiding this comment.
I'm not sure we want to document this right now. It's a bit of a blunt instrument and will disable all feature probing. I think we could improve usability, where you can specify something like S2N_QUIC_PLATFORM_FEATURES_OVERRIDE=default,-gso,-gro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Related issues:
related #2485
Description of changes:
Add a comment to the user guide about Docker and GSO.
Call-outs:
Docker host networking works fine with GSO, should I add that as an additional workaround?
Testing:
AWS CodeBuild
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.