fix(s2n-quic-transport): fix clippy beta warnings #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/clippy-beta-07-2022
branch
2 times, most recently
from
b5d70a0 to
bb9964f
Compare
camshaft
force-pushed
the
camshaft/clippy-beta-07-2022
branch
from
bb9964f to
d8ae1ea
Compare
|
can we do this in a |
I wish we could... but since this lint is unstable it needs to be applied conditionally depending on the clippy version. And to complicate things even more: they've deprecated |
toidiu
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Clippy introduced a new lint in beta that checks to see if Eq can be derived if PartialEq is also derived. This is fine for applications but it makes ensuring backward-compatibility in libraries more fragile. If a field is added that doesn't implement Eq, then the derive would have to be removed, which could break existing callers.
This change adds an allow for the new lint globally, since I don't think it's very compelling.
See rust-lang/rust-clippy#9063
I've also made beta clippy errors into warnings since it clutters up actual statuses every time clippy adds one of these things.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.