Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handlerOptions optional in RequestHandler #1695

Closed
trivikr opened this issue Nov 18, 2020 · 1 comment · Fixed by #1696
Closed

Make handlerOptions optional in RequestHandler #1695

trivikr opened this issue Nov 18, 2020 · 1 comment · Fixed by #1696
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Nov 18, 2020

Is your feature request related to a problem? Please describe.
Not a problem, but an empty hash needs to be passed for httpOptions when calling handle function.

Code links:

Describe the solution you'd like
Make handlerOptions optional in RequestHandler

Describe alternatives you've considered
Stick with required handlerOptions, as it's used internally by client code and not directly called by customers.

Additional context
This was noticed while writing new unit tests for node-http-handler in #1693

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant