Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Instance Refresh for EC2 Auto Scaling #181

Closed
stevehipwell opened this issue Jun 24, 2020 · 5 comments
Closed

Add support for Instance Refresh for EC2 Auto Scaling #181

stevehipwell opened this issue Jun 24, 2020 · 5 comments

Comments

@stevehipwell
Copy link
Contributor

Can the AWS Node Termination Handler handle the events triggered by Instance Refresh for EC2 Auto Scaling to provide a seamless worker upgrade path? If not is this something that could be supported?

@bwagner5
Copy link
Contributor

It's not possible to add support for Instance Refresh with the current daemonset implementation. We are tracking this issue #14 to support generic shutdown events by responding to ASG lifecycle hooks and events from EventBridge. But active development is not underway yet.

@bwagner5
Copy link
Contributor

bwagner5 commented Oct 8, 2020

Hey everyone! 👋 We have listened to your request to expand the aws-node-termination-handler to include all EC2 instances and not just Spot.

We have pushed a branch to the repo queue-processor that allows aws-node-termination-handler to run as a deployment in your cluster and respond to EventBridge termination events from ASG, EC2, and Spot.

Check out the new README on that branch and let us know what you think
https://github.com/aws/aws-node-termination-handler/tree/queue-processor

This new functionality is currently in Alpha, but we would love your feedback!

@philomory
Copy link

@bwagner5 Those links are 404s for me, has that branch been merged at this point?

@bwagner5
Copy link
Contributor

@philomory Yes, the queue-processor branched is merged into main now.

It was first released in https://github.com/aws/aws-node-termination-handler/releases/tag/v1.9.0

I'd recommend using the latest release, https://github.com/aws/aws-node-termination-handler/releases/tag/v1.11.0 to try it out

@philomory
Copy link

So, should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants