Skip to content

Commit 0379878

Browse files
authored
fix(logs): DataProtectionPolicy template key must be PascalCase (#33462)
### Issue # (if applicable) Closes #33408 Closes #26728 ### Reason for this change Invalid DataProtectionPolicy syntax ### Description of changes Change template key from camelCase > PascalCase ### Description of how you validated changes Unit + integration ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 7901f07 commit 0379878

File tree

11 files changed

+214
-203
lines changed

11 files changed

+214
-203
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/LogGroupIntegDefaultTestDeployAssertA9999A13.assets.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/aws-cdk-log-group-integ.assets.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/aws-cdk-log-group-integ.template.json

+27-27
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,13 @@
1717
"Type": "AWS::Logs::LogGroup",
1818
"Properties": {
1919
"DataProtectionPolicy": {
20-
"name": "policy-name",
21-
"description": "policy description",
22-
"version": "2021-06-01",
23-
"configuration": {
24-
"customDataIdentifier": [
25-
{
26-
"name": "EmployeeId",
27-
"regex": "EmployeeId-\\d{9}"
28-
}
29-
]
30-
},
31-
"statement": [
20+
"Name": "policy-name",
21+
"Description": "policy description",
22+
"Version": "2021-06-01",
23+
"Statement": [
3224
{
33-
"sid": "audit-statement-cdk",
34-
"dataIdentifier": [
25+
"Sid": "audit-statement-cdk",
26+
"DataIdentifier": [
3527
{
3628
"Fn::Join": [
3729
"",
@@ -58,16 +50,16 @@
5850
},
5951
"EmployeeId"
6052
],
61-
"operation": {
62-
"audit": {
63-
"findingsDestination": {
64-
"cloudWatchLogs": {
65-
"logGroup": {
53+
"Operation": {
54+
"Audit": {
55+
"FindingsDestination": {
56+
"CloudWatchLogs": {
57+
"LogGroup": {
6658
"Ref": "LogGroupLambdaAuditF8F47F46"
6759
}
6860
},
69-
"s3": {
70-
"bucket": {
61+
"S3": {
62+
"Bucket": {
7163
"Ref": "auditbucketidE6660EBD"
7264
}
7365
}
@@ -76,8 +68,8 @@
7668
}
7769
},
7870
{
79-
"sid": "redact-statement-cdk",
80-
"dataIdentifier": [
71+
"Sid": "redact-statement-cdk",
72+
"DataIdentifier": [
8173
{
8274
"Fn::Join": [
8375
"",
@@ -104,13 +96,21 @@
10496
},
10597
"EmployeeId"
10698
],
107-
"operation": {
108-
"deidentify": {
109-
"maskConfig": {}
99+
"Operation": {
100+
"Deidentify": {
101+
"MaskConfig": {}
110102
}
111103
}
112104
}
113-
]
105+
],
106+
"Configuration": {
107+
"CustomDataIdentifier": [
108+
{
109+
"Name": "EmployeeId",
110+
"Regex": "EmployeeId-\\d{9}"
111+
}
112+
]
113+
}
114114
},
115115
"RetentionInDays": 731
116116
},

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/cdk.out

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/integ.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/manifest.json

+22-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.js.snapshot/tree.json

+43-32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-logs/test/integ.log-group.ts

-1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,3 @@ class LogGroupIntegStack extends Stack {
2828
const app = new App();
2929
const stack = new LogGroupIntegStack(app, 'aws-cdk-log-group-integ');
3030
new IntegTest(app, 'LogGroupInteg', { testCases: [stack] });
31-
app.synth();

0 commit comments

Comments
 (0)