fix(cli): [object Object] in error message when CcApiContextProviderPlugin listResources throws
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tietew
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
approved these changes
Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 84.78% 85.00% +0.22%
==========================================
Files 204 204
Lines 35647 35647
Branches 4606 4627 +21
==========================================
+ Hits 30222 30301 +79
+ Misses 5272 5195 -77
+ Partials 153 151 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Tietew thanks for the fix! The integ test failure seems unrelated. I'll take care of this. Please don't sync the branch with |
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
|
Integ tests are partly blocked at the moment. I'm happy enough this works though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interporating
propertyMatchdirectly in error message causes[object Object]representation because it's an object.This PR wraps it in
JSON.stringify()to fix the message correctly.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license