Skip to content

Commit 4d3cdd5

Browse files
authored
fix(aws-cdk): CLI doesn't work on Node 16 (#59)
During the migration, we updated `cdk-from-cfn` to the latest version. Between version `0.162.1` and `0.189.0` a change to that package made it incompatible with Node 16 (requires Node 18+). Even though both Node 16 and Node 18 are EOL right now and everyone should be on Node 20+, just to be safe we'll roll back to an old version. This does mean that we have an old version of the spec used by `cdk migrate`. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent eed225a commit 4d3cdd5

File tree

7 files changed

+12
-5
lines changed

7 files changed

+12
-5
lines changed

.projenrc.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,8 @@ const cli = configureProject(
637637
],
638638
'camelcase@^6', // Non-ESM
639639
cdkAssets,
640-
'cdk-from-cfn',
640+
// A version that is guaranteed to still work on Node 16
641+
'cdk-from-cfn@0.162.1',
641642
'chalk@^4',
642643
'chokidar@^3',
643644
'decamelize@^5', // Non-ESM

packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES

+1-1
Original file line numberDiff line numberDiff line change
@@ -23884,7 +23884,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
2388423884

2388523885
----------------
2388623886

23887-
** cdk-from-cfn@0.189.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.189.0 | MIT OR Apache-2.0
23887+
** cdk-from-cfn@0.162.1 - https://www.npmjs.com/package/cdk-from-cfn/v/0.162.1 | MIT OR Apache-2.0
2388823888

2388923889
----------------
2389023890

packages/aws-cdk/.projen/deps.json

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-cdk/.projen/tasks.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/aws-cdk/THIRD_PARTY_LICENSES

+1-1
Original file line numberDiff line numberDiff line change
@@ -23677,7 +23677,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
2367723677

2367823678
----------------
2367923679

23680-
** cdk-from-cfn@0.189.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.189.0 | MIT OR Apache-2.0
23680+
** cdk-from-cfn@0.162.1 - https://www.npmjs.com/package/cdk-from-cfn/v/0.162.1 | MIT OR Apache-2.0
2368123681

2368223682
----------------
2368323683

packages/aws-cdk/package.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

yarn.lock

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)