-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(maintenance): cleaned up package.json
files
#1504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
filespackage.json
files
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
This item relates to automation
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
documentation
Improvements or additions to documentation
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
size/L
PRs between 100-499 LOC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The PR make some light changes to the
scripts
section of the variouspackage.json
files of the project. The main goal of these changes is to remove unused or redundant commands while also making it so that when they are published the files contain only the info strictly necessary. In doing so, the PR also should fix the issue causing theREADME.md
file of the Parameters utility to be missing.List of changes
prepare
script, the script was used to runnpm run build
before packaging the utilities, however this script also runs when installing which caused issues when runningnpm ci
(which required the--foreground-scripts
flag) due to the project being a monorepo written in TS.prebuild
script that is run before executingnpm run build
. The script removes any existing./lib
folder so that each build (especially local) is clean.prepack
script to run a custom script that removes unused fields from thepackage.json
file before packing & publishing an utility to npm, the script also applies the-alpha
or-beta
suffix to relevant utilities.build
scripts from theexamples
since each example has build commands related to SAM or CDK.package.json
file of the Parameters utility, a follow up PR will reorganize the package structure.private
so that it's not published, and added it to the Lerna config.Related issues, RFCs
Issue number: #1492
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.