Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestructureFrictionModelCombos [com1DFAdev] #941

Open
jtfisch opened this issue Nov 17, 2023 · 1 comment
Open

RestructureFrictionModelCombos [com1DFAdev] #941

jtfisch opened this issue Nov 17, 2023 · 1 comment
Assignees
Labels
com1DFAdev enhancement New feature or request featureRequest ideas or functions that would be useful

Comments

@jtfisch
Copy link
Contributor

jtfisch commented Nov 17, 2023

Description of topic

Restructure the choice of friction relations or other submodels (maybe allow direct implementation of user defined models and friction relations) this would allow to:

  • use combinations of e.g. coulomb + minshear + voellmy + samosATturbulent + .... in different combinations instead of different special modules
  • allow to reduce the possibility of different implementations
  • require some restructuring in naming and change the concept of how friction relations are defined

https://docs.avaframe.org/en/latest/theoryCom1DFA.html#friction-model

Related AvaFrame functions

probably also connected to entrainment or similar sub models and relations

**Related C-code files/functions/linenumbers

no idea

@jtfisch jtfisch added enhancement New feature or request featureRequest ideas or functions that would be useful labels Nov 17, 2023
@fso42
Copy link
Contributor

fso42 commented Nov 20, 2023

I am strongly against introducing a "logic" to combine any models / parameters! In my opinion, this only has disadvantages: unnecessarily complex, not easy to understand and I don't see any advantages in it! I think the effort of copying a line, extending it, modifiying and introducing the corresponding parameters is simple enough and sufficient in my opinion...

What we could do: combine all friction setup functions into a separate python file, so one only has to edit one file...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
com1DFAdev enhancement New feature or request featureRequest ideas or functions that would be useful
Projects
None yet
Development

No branches or pull requests

3 participants