Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com4] use raster functions (for .asc and .tif) from AvaFrame #1095

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[com4] use raster functions (for .asc and .tif) from AvaFrame #1095

wants to merge 2 commits into from

Conversation

PaulaSp3
Copy link
Contributor

@PaulaSp3 PaulaSp3 commented Feb 21, 2025 •
edited
Loading

  • use the raster - functions from avaframe.in2Trans.rasterUtils and avaframe.in1Data.getInput instead of avaframe.com4FlowPy.raserIo
  • avaframe.com4FlowPy.raserIois not needed anymore (can be deleted, not done yet..)
  • the only differences I recognized:
    • when writing rasterData now the noData values (before: nodata: -9999) -> but I still could change the if required
    • we flip upside down the rasters when reading in and writing, when doing that consistently, I could not recognize a problem yet.

@PaulaSp3 PaulaSp3 added enhancement New feature or request flowPyDev Ideas for future development labels Feb 21, 2025
@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw February 21, 2025 10:17
@PaulaSp3 PaulaSp3 linked an issue Feb 21, 2025 that may be closed by this pull request
Refactor com4 for new rasterUtils with tiff support #1058
Open
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 24, 2025

Code Climate has analyzed commit ee4784d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.4% (0.1% change).

View more on Code Climate.

@fso42 fso42 changed the title com4: use raster functions (for .asc and .tif) from AvaFrame [com4] use raster functions (for .asc and .tif) from AvaFrame Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuber-bfw ahuber-bfw Awaiting requested review from ahuber-bfw

At least 1 approving review is required to merge this pull request.

Assignees

@PaulaSp3 PaulaSp3

@ahuber-bfw ahuber-bfw

Labels
enhancement New feature or request flowPyDev Ideas for future development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor com4 for new rasterUtils with tiff support
2 participants
@PaulaSp3 @ahuber-bfw