Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement eip-5267 for structured eip-712 domain retrieval #49

Open
TimDaub opened this issue Sep 4, 2022 · 2 comments
Open

implement eip-5267 for structured eip-712 domain retrieval #49

TimDaub opened this issue Sep 4, 2022 · 2 comments

Comments

@TimDaub
Copy link
Member

TimDaub commented Sep 4, 2022

https://eips.ethereum.org/EIPS/eip-5267
@TimDaub
Copy link
Member Author

TimDaub commented Jan 6, 2023

@frangio shall we implement this in eip4973?

@frangio
Copy link
Contributor

frangio commented Jan 11, 2023

It does make EIP-712 signatures much more usable IMO so it's a good idea to include it in an implementation, but I'm not 100% sure it should be made a requirement at the EIP level. What do you think?

EIP-5267 will probably soon come built in with EIP712 in OpenZeppelin, but if it is made a requirement for EIP-4973 we will want to add it here manually as it will be faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frangio @TimDaub