Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Upgrades ScalaTest assertions #302

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Upgrades ScalaTest assertions #302

merged 1 commit into from
Feb 9, 2017

Conversation

cdupuis
Copy link
Contributor

@cdupuis cdupuis commented Feb 9, 2017

---
kind: "operation"
client: "rug-cli 0.23.0-SNAPSHOT"
executor:
  name: "UpgradeScalaTestAssertions"
  group: "atomist-rugs"
  artifact: "scala-editors"
  version: "0.1.0"
  origin:
    repo: "n/a"
    branch: "n/a"
    sha: "n/a"

```
---
kind: "operation"
client: "rug-cli 0.23.0-SNAPSHOT"
executor:
  name: "UpgradeScalaTestAssertions"
  group: "atomist-rugs"
  artifact: "scala-editors"
  version: "0.1.0"
  origin:
    repo: "n/a"
    branch: "n/a"
    sha: "n/a"

```
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2017

CLA assistant check
All committers have signed the CLA.

@cdupuis cdupuis requested a review from johnsonr February 9, 2017 10:51
@cdupuis
Copy link
Contributor Author

cdupuis commented Feb 9, 2017

@johnsonr added you as reviewer to let you decide whether or not you want to merge this in.

@kipz
Copy link
Contributor

kipz commented Feb 9, 2017

Love it! +1

@johnsonr johnsonr merged commit 6012eff into master Feb 9, 2017
@johnsonr johnsonr deleted the test_assertions branch February 9, 2017 11:46
@claymccoy
Copy link
Contributor

This is great.
One thought, DiagrammedAssertions given even better messages on failure and don't require the triple equals.
http://doc.scalatest.org/2.2.1/#org.scalatest.DiagrammedAssertions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants