Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid - search returns JSON but with content-type = text/html #1013

Closed
mvorisek opened this issue Mar 26, 2020 · 4 comments
Closed

Grid - search returns JSON but with content-type = text/html #1013

mvorisek opened this issue Mar 26, 2020 · 4 comments
Assignees

Comments

@mvorisek
Copy link
Member

Fix to return content type: application/json and fix other JSON responses if they are affected too.

@mvorisek mvorisek changed the title Grid search return JSON, but with content-type = text/html Grid - search returns JSON but with content-type = text/html Mar 26, 2020
@ibelar
Copy link
Contributor

ibelar commented Mar 29, 2020

I am not able to reproduce this. Can you share a little more details?

@mvorisek
Copy link
Member Author

mvorisek commented Mar 29, 2020

@ibelar Steps to reproduce:

  1. open https://ui.agiletoolkit.org/demos/grid.php
  2. open developer tools > network in your browser
  3. try to search something like x
  4. notice the AJAX request - https://ui.agiletoolkit.org/demos/grid.php?__atk_reload=atk_admin_grid_view&_q=x
  5. notice the response headers:
    image

Are you getting the same response content type?

PS: tested also locally with the latest develop

@ibelar
Copy link
Contributor

ibelar commented Mar 29, 2020

https://ui.agiletoolkit.org/demos/grid.php use old atk4/ui version 1.7.1

This was refactored in version 2.0

@ibelar ibelar closed this as completed Mar 29, 2020
@mvorisek
Copy link
Member Author

@ibelar You are right, not sure how I came to it in the latest version, but then I retested it in the demo/1.7.1...

related with #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants