Skip to content

Commit e403892

Browse files
committed
remove "teleport to" attr after teleport
1 parent 485adb6 commit e403892

File tree

7 files changed

+13
-10
lines changed

7 files changed

+13
-10
lines changed

js/src/Helper/elementTeleportObserver.js

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ function handleElementsTeleport(elems) {
3838
}
3939

4040
target.append(elem);
41+
42+
elem.removeAttribute(attributeToName);
4143
}
4244
}
4345

js/src/JqueryPlugin/AbstractPlugin.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import $ from 'external/jquery';
33
/**
44
* Base implementation of jQuery plugin in Agile Toolkit.
55
*/
6-
export default class AbstractPlugin {
6+
export default class AtkAbstractPlugin {
77
constructor(element, options) {
88
this.$el = $(element);
99
this.settings = options;

js/src/Service/apiService.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ class ApiService {
104104
responseBody = null;
105105

106106
if ($target.hasClass('ui modal') || $target.hasClass('atk-right-panel')) {
107-
// https://github.com/atk4/ui/pull/2142/commits/aed22bb88a
107+
// introduced in https://github.com/atk4/ui/pull/2142/commits/aed22bb88a
108108
// TODO move into teleport observer
109-
// TODO how to reproduce?
109+
// can be reproduced using /demos/data-action/jsactions2.php "Argument/Preview" action
110110

111111
$.each([...$target[0].childNodes], (i, node) => {
112112
if (node instanceof Element && node.classList.contains('ui') && node.classList.contains('dimmer')) {

public/js/atkjs-ui.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,7 @@ function handleElementsTeleport(elems) {
410410
elemOrig.remove();
411411
}
412412
target.append(elem);
413+
elem.removeAttribute(attributeToName);
413414
}
414415
}
415416
function handleObserverRecords(mutationRecords) {
@@ -728,7 +729,7 @@ __webpack_require__.r(__webpack_exports__);
728729
"use strict";
729730
__webpack_require__.r(__webpack_exports__);
730731
/* harmony export */ __webpack_require__.d(__webpack_exports__, {
731-
/* harmony export */ "default": () => (/* binding */ AbstractPlugin)
732+
/* harmony export */ "default": () => (/* binding */ AtkAbstractPlugin)
732733
/* harmony export */ });
733734
/* harmony import */ var external_jquery__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! external/jquery */ "external/jquery");
734735
/* harmony import */ var external_jquery__WEBPACK_IMPORTED_MODULE_0___default = /*#__PURE__*/__webpack_require__.n(external_jquery__WEBPACK_IMPORTED_MODULE_0__);
@@ -737,7 +738,7 @@ __webpack_require__.r(__webpack_exports__);
737738
/**
738739
* Base implementation of jQuery plugin in Agile Toolkit.
739740
*/
740-
class AbstractPlugin {
741+
class AtkAbstractPlugin {
741742
constructor(element, options) {
742743
this.$el = external_jquery__WEBPACK_IMPORTED_MODULE_0___default()(element);
743744
this.settings = options;
@@ -2564,9 +2565,9 @@ class ApiService {
25642565
}
25652566
responseBody = null;
25662567
if ($target.hasClass('ui modal') || $target.hasClass('atk-right-panel')) {
2567-
// https://github.com/atk4/ui/pull/2142/commits/aed22bb88a
2568+
// introduced in https://github.com/atk4/ui/pull/2142/commits/aed22bb88a
25682569
// TODO move into teleport observer
2569-
// TODO how to reproduce?
2570+
// can be reproduced using /demos/data-action/jsactions2.php "Argument/Preview" action
25702571

25712572
external_jquery__WEBPACK_IMPORTED_MODULE_2___default().each([...$target[0].childNodes], (i, node) => {
25722573
if (node instanceof Element && node.classList.contains('ui') && node.classList.contains('dimmer')) {

public/js/atkjs-ui.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/js/atkjs-ui.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/js/atkjs-ui.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)