Card with entity UA must not reload data again (#2005)

Author: mvorisek

demos/data-action/factory-view.php

@@ -56,6 +56,9 @@ protected function getCardButton(Model\UserAction $action)
 DemoActionsUtil::setupDemoActions($country);
 $country = $country->loadBy($country->fieldName()->iso, 'fr');
 $country->name .= ' NO RELOAD';
+// suppress dirty field exception
+// https://github.com/atk4/data/blob/35dd7b7d95909cfe574b15e32b7cc57c39a16a58/src/Model/UserAction.php#L164
+unset($country->getDirtyRef()[$country->fieldName()->name]);
 
 $cardActions = Card::addTo($app, ['useLabel' => true, 'executorFactory' => new $myFactory()]);
 $cardActions->setModel($country);

src/Card.php

@@ -216,11 +216,16 @@ public function addClickAction(Model\UserAction $action, Button $button = null,
     {
         $btn = $this->addButton($button ?? $this->getExecutorFactory()->createTrigger($action, ExecutorFactory::CARD_BUTTON));
 
+        $cardDeck = $this->getClosestOwner(CardDeck::class);
+
         $defaults = [];
 
         // Setting arg for model id. $args[0] is consider to hold a model id, i.e. as a js expression.
         if ($this->model && $this->model->isLoaded() && !isset($args[0])) {
             $defaults[] = $this->model->getId();
+            if ($cardDeck === null && !$action->isOwnerEntity()) {
+                $action = $action->getActionForEntity($this->model);
+            }
         }
 
         if ($args !== []) {
@@ -231,7 +236,6 @@ public function addClickAction(Model\UserAction $action, Button $button = null,
             $defaults['confirm'] = $confirm;
         }
 
-        $cardDeck = $this->getClosestOwner(CardDeck::class);
         if ($cardDeck !== null) {
             // mimic https://github.com/atk4/ui/blob/3c592b8f10fe67c61f179c5c8723b07f8ab754b9/src/Crud.php#L140
             // based on https://github.com/atk4/ui/blob/3c592b8f10fe67c61f179c5c8723b07f8ab754b9/src/UserAction/SharedExecutorsContainer.php#L24

tests-behat/card.feature

@@ -4,8 +4,7 @@ Feature: Card
     Given I am on "data-action/factory-view.php"
     Then I click using selector "i.eye.icon"
     Then Modal is open with text "Display Preview prior to run the action"
-    # TODO fix
-    # Then Modal is open with text "Previewing country France NO RELOAD"
+    Then Modal is open with text "Previewing country France NO RELOAD"
     Then I press Modal button "Preview"
     Then Toast display should contain text "Success: Done previewing France"