Add Github workflows (actions) (#848)

* workflow

* Setting current dependencies

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* Fix unit test on Windows paths

* Remove file db.github.php from Demo functional test check.

* Apply fixes from StyleCI

* Fix some Type Hints

* Apply fixes from StyleCI

Author: romaninsh

.github/workflows/bundler.yml

@@ -0,0 +1,28 @@
+name: Bundler
+
+on:
+  create:
+    branches:
+      - 'release/*'
+
+jobs:
+  autocommit:
+    runs-on: ubuntu-latest
+    container:
+      image: atk4/image:latest # https://github.com/atk4/image
+    steps:
+      - uses: actions/checkout@master
+      - run: |
+          sed -i -e '/atk4\/data/d' composer.json
+          sed -i -e '/atk4\/core/d' composer.json
+          cat composer.json
+          composer require atk4/core atk4/data
+          composer update
+
+      - uses: teaminkling/autocommit@master
+        with:
+          commit-message: Setting current dependencies
+      - uses: ad-m/github-push-action@master
+        with:
+          branch: ${{ github.ref }}
+          github_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release-drafter.yml

@@ -0,0 +1,16 @@
+name: Release Drafter
+
+on:
+  push:
+    # branches to consider in the event; optional, defaults to all
+    branches:
+      - develop
+
+jobs:
+  update_release_draft:
+    runs-on: ubuntu-latest
+    steps:
+      # Drafts your next Release notes as Pull Requests are merged into "master"
+      - uses: toolmantim/release-drafter@v5.2.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/unit-tests.yml

@@ -0,0 +1,61 @@
+name: Unit Testing
+
+on:
+  pull_request
+
+jobs:
+  unit-test:
+    name: Unit Testing
+    runs-on: ubuntu-latest
+    container:
+      image: atk4/image:latest # https://github.com/atk4/image
+    strategy:
+      matrix:
+        php: ['7.2', '7.3', 'latest']
+    services:
+      mysql:
+        image: mysql:5.7
+        env:
+          MYSQL_ROOT_PASSWORD: password
+          DB_DATABASE: db
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5
+    steps:
+      - uses: actions/checkout@v1
+      - name: Get Composer Cache Directory
+        id: composer-cache
+        run: |
+          echo "::set-output name=dir::$(composer config cache-files-dir)"
+      - uses: actions/cache@v1
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('composer.json') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-
+
+      - run: composer install --no-progress --no-suggest --prefer-dist --optimize-autoloader
+
+      - name: Install dependencies and SQL
+        run: |
+          mkdir -p coverage
+          apk add npm
+          npm install -g less clean-css uglify-js
+          mysql -uroot -ppassword -h mysql -e 'CREATE DATABASE atk4;'
+          mysql -uroot -ppassword -h mysql atk4 < demos/atk4.sql
+
+          mv demos/db.github.php demos/db.php
+          (cd js; npm install; npm run build)
+          #lessc public/agileui.less public/agileui.css  --clean-css="--s1 --advanced --compatibility=ie8" --source-map
+          #uglifyjs --compress -- public/agileui.js > public/agileui.min.js
+
+      - name: Unit Testing
+        run: vendor/bin/phpunit --coverage-text --coverage-clover=coverage.xml
+
+#      - name: Merge coverage logs
+#        run: vendor/bin/phpcov merge build/logs/ --clover build/logs/cc.xml;
+
+      - uses: codecov/codecov-action@v1
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          file: covearge.xml
+
+

composer.json

@@ -15,10 +15,10 @@
         }
     ],
     "require": {
-        "atk4/data": "dev-develop",
-        "atk4/core": "dev-develop",
         "php": ">=7.2.0",
-        "ext-json": "*"
+        "ext-json": "*",
+        "atk4/core": "dev-develop",
+        "atk4/data": "dev-develop"
     },
     "require-dev": {
         "phpunit/phpunit": "<6",

demos/db.github.php

@@ -0,0 +1,3 @@
+<?php
+
+$db = new \atk4\data\Persistence\SQL('mysql:dbname=atk4;host=mysql', 'root', 'password');

src/ActionExecutor/Basic.php

@@ -62,7 +62,7 @@ class Basic extends \atk4\ui\View implements Interface_
      *
      * @param \atk4\data\UserAction\Generic $action
      */
-    public function setAction(\atk4\data\UserAction\Generic $action)
+    public function setAction(\atk4\data\UserAction\Generic $action) : void
     {
         $this->action = $action;
     }
@@ -134,6 +134,8 @@ protected function initPreview()
     /**
      * Will call $action->execute() with the correct arguments.
      *
+     * @throws \atk4\core\Exception
+     *
      * @return mixed
      */
     public function jsExecute()
@@ -154,7 +156,7 @@ public function jsExecute()
     /**
      * Will add header if set.
      *
-     * @throws Exception
+     * @throws \atk4\core\Exception
      */
     public function addHeader()
     {

tests/BuiltInWebServerAbstract.php

@@ -30,8 +30,8 @@ public static function setUpBeforeClass()
 
         if (!file_exists(getcwd().'/demos/coverage.php')) {
             file_put_contents(
-                getcwd().'/demos/coverage.php',
-                file_get_contents(getcwd().'/tools/coverage.php')
+                implode(DIRECTORY_SEPARATOR, [dirname(__DIR__), 'demos', 'coverage.php']),
+                file_get_contents(implode(DIRECTORY_SEPARATOR, [dirname(__DIR__), 'tools', 'coverage.php']))
             );
         }
 

tests/DemoCallExitTest.php

@@ -30,7 +30,7 @@ class DemoCallExitTest extends BuiltInWebServerAbstract
     public function testableDemoFilesdataProvider()
     {
         $files = [];
-        foreach (scandir(getcwd().DIRECTORY_SEPARATOR.'demos') as $file) {
+        foreach (scandir(dirname(__DIR__).DIRECTORY_SEPARATOR.'demos') as $file) {
             if (is_dir($file) || substr($file, -3) !== 'php') {
                 continue;
             }
@@ -41,6 +41,7 @@ public function testableDemoFilesdataProvider()
                 case 'db.example.php': // exclude - is a setup file
                 case 'db.php': // exclude - is a setup file
                 case 'db.travis.php': // exclude - is a setup file
+                case 'db.github.php': // exclude - is a setup file
                 case 'coverage.php': // exclude - is the coverage file
                 case 'somedatadef.php': // exclude - is a setup file
                 case 'layouts_nolayout.php': // exclude - output only a partial html