fix lookup (#1661)

Author: ibelar

demos/_includes/DemoLookup.php

@@ -42,9 +42,9 @@ protected function initQuickNewRecord()
         $vp->set(function ($page) {
             $form = \Atk4\Ui\Form::addTo($page);
 
-            $model = clone $this->model;
+            $entity = $this->model->createEntity();
 
-            $form->setModel($model->onlyFields($this->plus['fields'] ?? []));
+            $form->setModel($entity->onlyFields($this->plus['fields'] ?? []));
 
             $form->onSubmit(function (\Atk4\Ui\Form $form) {
                 // Prevent from saving

demos/form-control/lookup.php

@@ -39,7 +39,12 @@
 ]);
 
 $form->onSubmit(function (Form $form) {
-    $str = $form->model->ref('country1')->get('name') . ' ' . $form->model->ref('country2')->get('name') . ' ' . (new Country($form->getApp()->db))->tryLoad($form->model->get('country3'))->get('name');
+    $str = $form->model->ref('country1')->get(Country::hinting()->fieldName()->name);
+    $str .= '; ';
+    $str .= $form->model->ref('country2')->get(Country::hinting()->fieldName()->name);
+    $str .= '; ';
+    $str .= (new Country($form->getApp()->db))->tryLoad($form->model->get('country3'))->get(Country::hinting()->fieldName()->name);
+
     $view = new \Atk4\Ui\Message('Select:'); // need in behat test.
     $view->invokeInit();
     $view->text->addParagraph($str);

src/Form/Control/Lookup.php

@@ -270,9 +270,9 @@ protected function initQuickNewRecord()
         $vp->set(function ($page) {
             $form = \Atk4\Ui\Form::addTo($page);
 
-            $model = clone $this->model;
+            $entity = $this->model->createEntity();
 
-            $form->setModel($model->onlyFields($this->plus['fields'] ?? []));
+            $form->setModel($entity->onlyFields($this->plus['fields'] ?? []));
 
             $form->onSubmit(function (\Atk4\Ui\Form $form) {
                 $form->model->save();

tests-behat/lookup.feature

@@ -14,4 +14,15 @@ Feature: Lookup
     Then I press menu button "Add Category" using class "atk-grid-menu"
     Then I select value "Beverages" in lookup "category"
     Then I press Modal button "Save"
-    Then Toast display should contains text 'Beverages'
+    Then Toast display should contains text "Beverages"
+
+  Scenario: Testing lookup add
+    Given I am on "form-control/lookup.php"
+    Then I press button "Add New"
+    When I fill in "atk_fp_country__name" with "New country"
+    When I fill in "atk_fp_country__iso" with "AA"
+    When I fill in "atk_fp_country__iso3" with "AAA"
+    When I fill in "atk_fp_country__numcode" with "88"
+    When I fill in "atk_fp_country__phonecode" with "8"
+    Then I press Modal button "Save"
+    Then Toast display should contains text "Form submit!"