[fix] Model::duplicate

Author: georgehristov

src/Model.php

@@ -1178,12 +1178,14 @@ public function reload()
      */
     public function duplicate($newId = null)
     {
-        $this->setId(null);
+        $this->entityId = null;
 
         if ($this->id_field) {
             $this->setId($newId);
         }
 
+        $this->dirty = $this->get();
+
         return $this;
     }
 

tests/RandomTest.php

@@ -497,6 +497,49 @@ public function testNewInstance()
         $this->assertTrue(isset($a->persistence));
     }
 
+    public function testDuplicate1()
+    {
+        $this->setDb([
+            'rate' => [
+                ['dat' => '18/12/12', 'bid' => 3.4, 'ask' => 9.4],
+                ['dat' => '12/12/12', 'bid' => 8.3, 'ask' => 9.2],
+            ],
+        ]);
+
+        $db = new Persistence\Sql($this->db->connection);
+        $m = new Model_Rate($db);
+
+        $m->load(1)->duplicate()->save();
+
+        $this->assertSame([
+            ['dat' => '18/12/12'],
+            ['dat' => '12/12/12'],
+            ['dat' => '18/12/12'],
+        ], $m->export(['dat']));
+    }
+
+    public function testDuplicate2()
+    {
+        $this->setDb([
+            'rate' => [
+                ['dat' => '18/12/12', 'bid' => 3.4, 'ask' => 9.4],
+                ['dat' => '12/12/12', 'bid' => 8.3, 'ask' => 9.2],
+            ],
+        ]);
+
+        $db = new Persistence\Sql($this->db->connection);
+        $m = new Model_Rate($db);
+
+        $m->load(1)->duplicate(2)->save();
+
+        $this->assertSame(2, $m->getId());
+
+        $this->assertSame([
+            ['id' => '1', 'dat' => '18/12/12', 'bid' => '3.4', 'ask' => '9.4'],
+            ['id' => '2', 'dat' => '18/12/12', 'bid' => '3.4', 'ask' => '9.4'],
+        ], $m->export());
+    }
+
     public function testTableNameDots()
     {
         $d = new Model($this->db, 'db2.doc');