Fix native binary for PostgreSQL

Author: mvorisek

src/Persistence/Sql/BinaryTypeCompatibilityTypecastTrait.php

@@ -47,7 +47,9 @@ private function binaryTypeValueDecode(string $value): string
 
     private function binaryTypeIsEncodeNeeded(Type $type): bool
     {
-        // TODO PostgreSQL tests fail without binary compatibility typecast
+        // values for PostgreSQL are stored natively, but we need to encode first
+        // to hold the binary type info for PDO parameter type binding
+
         $platform = $this->getDatabasePlatform();
         if ($platform instanceof PostgreSQL94Platform
             || $platform instanceof SQLServer2012Platform
@@ -76,7 +78,10 @@ public function typecastLoadField(Field $field, $value)
         $value = parent::typecastLoadField($field, $value);
 
         if ($value !== null && $this->binaryTypeIsEncodeNeeded($field->getTypeObject())) {
-            $value = $this->binaryTypeValueDecode($value);
+            if (!$this->getDatabasePlatform() instanceof PostgreSQL94Platform
+                || $this->binaryTypeValueIsEncoded($value)) {
+                $value = $this->binaryTypeValueDecode($value);
+            }
         }
 
         return $value;

src/Persistence/Sql/Expression.php

@@ -5,6 +5,7 @@
 namespace Atk4\Data\Persistence\Sql;
 
 use Atk4\Core\WarnDynamicPropertyTrait;
+use Atk4\Data\Persistence\Sql as SqlPersistence;
 use Doctrine\DBAL\Connection as DbalConnection;
 use Doctrine\DBAL\Exception as DbalException;
 use Doctrine\DBAL\ParameterType;
@@ -528,6 +529,14 @@ public function execute(object $connection = null): object
                         $type = ParameterType::STRING;
                     } elseif (is_string($val)) {
                         $type = ParameterType::STRING;
+
+                        if ($this->connection->getDatabasePlatform() instanceof PostgreSQL94Platform) {
+                            $dummySqlPersistence = new SqlPersistence($this->connection);
+                            if (\Closure::bind(fn () => $dummySqlPersistence->binaryTypeValueIsEncoded($val), null, SqlPersistence::class)()) {
+                                $val = \Closure::bind(fn () => $dummySqlPersistence->binaryTypeValueDecode($val), null, SqlPersistence::class)();
+                                $type = ParameterType::BINARY;
+                            }
+                        }
                     } elseif (is_resource($val)) {
                         throw new Exception('Resource type is not supported, set value as string instead');
                     } else {