fix Field::normalize/compare

Author: mvorisek

src/Field.php

@@ -187,8 +187,10 @@ public function normalize($value)
                             } else {
                                 throw new Exception('Must not be boolean type');
                             }
-                        } elseif (is_scalar($value)) {
+                        } elseif (is_int($value)) {
                             $value = (string) $value;
+                        } elseif (is_float($value)) {
+                            $value = Expression::castFloatToString($value);
                         } else {
                             throw new Exception('Must be scalar');
                         }
@@ -364,7 +366,12 @@ private function getValueForCompare($value): ?string
             return null;
         }
 
-        return (string) $this->typecastSaveField($value, true);
+        $res = $this->typecastSaveField($value, true);
+        if (is_float($res)) {
+            return Expression::castFloatToString($res);
+        }
+
+        return (string) $res;
     }
 
     /**

src/Persistence/Sql/Expression.php

@@ -630,6 +630,8 @@ final public static function castFloatToString(float $value): string
         $precisionBackup = ini_get('precision');
         try {
             // loop needed, see https://github.com/php/php-src/issues/8509
+            // fixed precision of 17 for conversion can render unneeded decimal digits like
+            // 0.40000000000000002 although 0.4 is enough to represent such float number exactly
             for ($i = 1; $i <= 17; ++$i) {
                 ini_set('precision', (string) $i);
                 $res = (string) $value;

tests/TypecastingTest.php

@@ -109,6 +109,11 @@ public function testType(): void
         unset($duplicate['id']);
 
         $this->assertEquals($first, $duplicate);
+
+        $m->load(2)->set('float', 8.202343767574731)->save();
+        // pack is needed to compare float numbers exactly, see https://github.com/sebastianbergmann/phpunit/issues/4966
+        // remove bin2hex/pack once fixed in phpunit officially
+        $this->assertSame(bin2hex(pack('e', 8.202343767574731)), bin2hex(pack('e', $m->load(2)->get('float'))));
     }
 
     public function testEmptyValues(): void