Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow/prioritize setter methods in DIContainerTrait::setDefaults() #206

Closed
mvorisek opened this issue May 16, 2020 · 2 comments
Closed

Allow/prioritize setter methods in DIContainerTrait::setDefaults() #206

mvorisek opened this issue May 16, 2020 · 2 comments
Labels

Comments

@mvorisek
Copy link
Member

mvorisek commented May 16, 2020

public function setDefaults(array $properties, bool $passively = false)

proposal to call setXX() if exists instead of setting the XX property directly

@mvorisek mvorisek changed the title Prioritize setter methods in DIContainerTrait::setDefaults() Allow/prioritize setter methods in DIContainerTrait::setDefaults() May 16, 2020
@abbadon1334
Copy link
Collaborator

abbadon1334 commented May 16, 2020

this is a logical idea, but usually i setDefaults and validate if all required dependency is in place correctly in constructor, and then when object is add to his owner i continue what i have to do during init, because only there i have the $app.

@mvorisek
Copy link
Member Author

mvorisek commented Jun 2, 2022

I do not want to pursue this issue now

@mvorisek mvorisek closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants