Merge pull request #1237 from atc0005/i1235-fix-sans-collection-length-check-dev-branch

atc0005 · web-flow · commit b5072cb8aba1 · 2025-02-12T05:49:36.000-06:00
Fix SANs length check in expiration validation
diff --git a/internal/certs/validation-expiration.go b/internal/certs/validation-expiration.go
@@ -727,7 +727,7 @@ func (evr ExpirationValidationResult) Status() string {
 
 	// but if it is, use the first SubjectAlternateName field in its place
 	if nextCertToExpire.Subject.CommonName == "" {
-		if len(nextCertToExpire.DNSNames[0]) > 0 {
+		if len(nextCertToExpire.DNSNames) > 0 {
 			nextCertToExpireServerName = nextCertToExpire.DNSNames[0]
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,7 @@ func (evr ExpirationValidationResult) Status() string {`
`727`	`727`
`728`	`728`	`// but if it is, use the first SubjectAlternateName field in its place`
`729`	`729`	`if nextCertToExpire.Subject.CommonName == "" {`
`730`		`- if len(nextCertToExpire.DNSNames[0]) > 0 {`
	`730`	`+ if len(nextCertToExpire.DNSNames) > 0 {`
`731`	`731`	`nextCertToExpireServerName = nextCertToExpire.DNSNames[0]`
`732`	`732`	`}`
`733`	`733`	`}`