Merge pull request #1236 from atc0005/i1235-fix-sans-collection-length-check

atc0005 · web-flow · commit 95eb1831b255 · 2025-02-12T05:49:16.000-06:00
Fix SANs length check in expiration validation
diff --git a/internal/certs/validation-expiration.go b/internal/certs/validation-expiration.go
@@ -706,7 +706,7 @@ func (evr ExpirationValidationResult) Status() string {
 
 	// but if it is, use the first SubjectAlternateName field in its place
 	if nextCertToExpire.Subject.CommonName == "" {
-		if len(nextCertToExpire.DNSNames[0]) > 0 {
+		if len(nextCertToExpire.DNSNames) > 0 {
 			nextCertToExpireServerName = nextCertToExpire.DNSNames[0]
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -706,7 +706,7 @@ func (evr ExpirationValidationResult) Status() string {`
`706`	`706`
`707`	`707`	`// but if it is, use the first SubjectAlternateName field in its place`
`708`	`708`	`if nextCertToExpire.Subject.CommonName == "" {`
`709`		`- if len(nextCertToExpire.DNSNames[0]) > 0 {`
	`709`	`+ if len(nextCertToExpire.DNSNames) > 0 {`
`710`	`710`	`nextCertToExpireServerName = nextCertToExpire.DNSNames[0]`
`711`	`711`	`}`
`712`	`712`	`}`