Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract action base prefix checks #2014

Open
ethanoroshiba opened this issue Mar 6, 2025 · 0 comments · May be fixed by #2015
Open

abstract action base prefix checks #2014

ethanoroshiba opened this issue Mar 6, 2025 · 0 comments · May be fixed by #2015
Assignees
Labels
code-quality refactor code refactoring or maintainence sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

We currently perform all address base prefix checks manually in each check_and_execute implementation. We should abstract these such that they are performed for every action automatically via something like trait impls for all actions. This will make it more difficult to forget to implement these checks, since the trait will be required, and will also allow for a more streamlined unit-testing process of these checks.

@ethanoroshiba ethanoroshiba added code-quality refactor code refactoring or maintainence sequencer pertaining to the astria-sequencer crate labels Mar 6, 2025
@ethanoroshiba ethanoroshiba self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality refactor code refactoring or maintainence sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant