Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky expect failures in resolver #1585

Closed
hauntsaninja opened this issue Feb 17, 2024 · 3 comments
Closed

Flaky expect failures in resolver #1585

hauntsaninja opened this issue Feb 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@hauntsaninja
Copy link
Contributor

hauntsaninja commented Feb 17, 2024

Getting the following segfault:

thread 'main' panicked at crates/uv-resolver/src/resolution.rs:135:30:
Every package should have metadata

Repro:

In [5]: Counter(subprocess.run("rm -rf .venv; uv venv --seed; uv pip install --no-cache --link-mode=copy --no-deps gpustat==1.1.1", shell=True).returncode for _ in range(100))
Out[5]: Counter({101: 73, 0: 27})

#1583 should improve the error message (I had to do some bisection to narrow it down to a single package)

With #1583 it appears there's some connection to setuptools-scm

Similar message reported in this comment: #1484 (comment)

@charliermarsh
Copy link
Member

Awesome, thanks! Will fix.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 17, 2024
@charliermarsh charliermarsh self-assigned this Feb 17, 2024
@charliermarsh
Copy link
Member

I can reproduce this on some old commits (I randomly tried c1eb613), but not on main, so I think it's resolved, at least on main? Will re-open if not.

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Feb 21, 2024

Thank you! I bisected the fix commit to #1607 , hopefully there's something in there that explains the formerly non-deterministic behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants