From 8cfe202e4e7b338c9a7eeca68b6f1bb2ad32f128 Mon Sep 17 00:00:00 2001 From: Zanie Blue Date: Tue, 11 Jun 2024 15:49:15 -0400 Subject: [PATCH] Improve output when an older toolchain version is already installed (#4248) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit e.g. ``` ❯ uv toolchain install Found installed toolchain 'cpython-3.9.19-macos-aarch64-none' A toolchain is already installed. Use `uv toolchain install ` to install a specific toolchain ``` instead of ``` ❯ uv toolchain install Using latest Python version Found installed toolchain 'cpython-3.9.19-macos-aarch64-none' Already installed at /Users/zb/Library/Application Support/uv/toolchains/cpython-3.9.19-macos-aarch64-none ``` --- crates/uv/src/commands/toolchain/install.rs | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/crates/uv/src/commands/toolchain/install.rs b/crates/uv/src/commands/toolchain/install.rs index 2f596671149f..844896056afb 100644 --- a/crates/uv/src/commands/toolchain/install.rs +++ b/crates/uv/src/commands/toolchain/install.rs @@ -45,7 +45,6 @@ pub(crate) async fn install( } request } else { - writeln!(printer.stderr(), "Using latest Python version")?; ToolchainRequest::default() }; @@ -58,11 +57,19 @@ pub(crate) async fn install( "Found installed toolchain '{}'", toolchain.key() )?; - writeln!( - printer.stderr(), - "Already installed at {}", - toolchain.path().user_display() - )?; + + if matches!(request, ToolchainRequest::Any) { + writeln!( + printer.stderr(), + "A toolchain is already installed. Use `uv toolchain install ` to install a specific toolchain.", + )?; + } else { + writeln!( + printer.stderr(), + "Already installed at {}", + toolchain.path().user_display() + )?; + } return Ok(ExitStatus::Success); }