Fix cascade detach to actually cascade #16880
Merged
+220
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #15960 The issue here is that when the first graph of Added entities are replaces by the second graph, it causes the first graph to be detached, but this was only happening at the first level of the graph. Other test changes are because we were relying on being able to detach a principal without it cascading, even though cascades are configured.
ajcvickers
requested review from
AndriySvyryd,
bricelam,
maumar,
roji and
smitpatel
AndriySvyryd
approved these changes
Aug 1, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15960
The issue here is that when the first graph of Added entities are replaces by the second graph, it causes the first graph to be detached, but this was only happening at the first level of the graph.
Other test changes are because we were relying on being able to detach a principal without it cascading, even though cascades are configured.