Use field/properties appropriately from query #16796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
AndriySvyryd,
roji,
smitpatel and
bricelam
and removed request for
AndriySvyryd
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
| /// </summary> | ||
| void AddRange([NotNull] object instance, [NotNull] IEnumerable<object> values); | ||
| bool Add([NotNull] object instance, [NotNull] object value, bool forMaterialization); |
There was a problem hiding this comment.
This is another interface that is used directly in the providers and we should consider making public.
AndriySvyryd
approved these changes
Jul 28, 2019
Fixes #16287 Ended up being quite a can of worms--cleaned up some CLR accessor code that is no longer being used (it was there for old pipeline) and found several additional bugs in the same area.
ajcvickers
force-pushed
the
BeurocraticLlama0727
branch
from
a15fdc3 to
fb64207
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16287
Ended up being quite a can of worms--cleaned up some CLR accessor code that is no longer being used (it was there for old pipeline) and found several additional bugs in the same area.