Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to (localdb)\MSSQLLocalDB #895

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jun 4, 2019

Part of #189

@bricelam bricelam marked this pull request as ready for review June 5, 2019 01:55
@bricelam bricelam requested a review from ajcvickers June 5, 2019 01:55
/// Initializes a new instance of the <see cref="LocalDbConnectionFactory"/> class.
/// </summary>
public LocalDbConnectionFactory()
: this("mssqllocaldb")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better hope they don't change it again!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been the same for 4 major SQL Server versions now

@ajcvickers
Copy link
Contributor

@divega @bricelam Do you think we should announce this as a breaking change?

@divega
Copy link
Contributor

divega commented Jun 6, 2019

@ajcvickers Maybe we should start putting together a What's new page for EF 6.3 in the docs and put it there. But I am fine with announcing it as a breaking changes via other means as well.

@ajcvickers
Copy link
Contributor

Yes, the What's New page sounds good. Let's start with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants