Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds theme selector to switch between light and dark theme variants #103

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

Also adds light app theme

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes #0
  • Connects #0

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #103 into master will increase coverage by 1.03%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
+ Coverage     77.53%   78.57%   +1.03%     
- Complexity       96      102       +6     
============================================
  Files            11       11              
  Lines           650      686      +36     
  Branches         81       89       +8     
============================================
+ Hits            504      539      +35     
- Misses           84       85       +1     
  Partials         62       62
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 82.55% <89.47%> (+1.67%) 17 <5> (+6) ⬆️
...ashutoshgngwr/noice/fragment/SleepTimerFragment.kt 90% <0%> (+4.51%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7852744...5745198. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 626a0f4 into master Mar 19, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/app-themes branch March 19, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant