From 73c9496c12bb1bf4d925061ff3b528b5ef6354fd Mon Sep 17 00:00:00 2001 From: Mauricio Gomes Date: Sun, 6 Jul 2014 17:46:53 -0400 Subject: [PATCH 1/2] Add support for larger Twitter profile images --- lib/omniauth/strategies/twitter.rb | 2 ++ spec/omniauth/strategies/twitter_spec.rb | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/lib/omniauth/strategies/twitter.rb b/lib/omniauth/strategies/twitter.rb index d29c5489..0d14f9f4 100644 --- a/lib/omniauth/strategies/twitter.rb +++ b/lib/omniauth/strategies/twitter.rb @@ -71,6 +71,8 @@ def image_url original_url.sub('normal', 'bigger') when 'original' original_url.sub('_normal', '') + when '400x400' + original_url.sub('400x400', '400x400') else original_url end diff --git a/spec/omniauth/strategies/twitter_spec.rb b/spec/omniauth/strategies/twitter_spec.rb index e352abfe..ce918daf 100644 --- a/spec/omniauth/strategies/twitter_spec.rb +++ b/spec/omniauth/strategies/twitter_spec.rb @@ -44,6 +44,14 @@ expect(subject.info[:image]).to eq('https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_mini.png') end + it 'should return secure image with size specified' do + @options = { :secure_image_url => 'true', :image_size => '400x400' } + allow(subject).to receive(:raw_info).and_return( + { 'profile_image_url_https' => 'https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_400x400.png' } + ) + expect(subject.info[:image]).to eq('https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_400x400.png') + end + it 'should return normal image by default' do allow(subject).to receive(:raw_info).and_return( { 'profile_image_url' => 'http://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' } From 8efa4a2a712a8a838e0dd69c42e50ce09577da35 Mon Sep 17 00:00:00 2001 From: Mauricio Gomes Date: Sun, 6 Jul 2014 17:53:49 -0400 Subject: [PATCH 2/2] Replace default thumbnail suffix with 400x400 --- lib/omniauth/strategies/twitter.rb | 2 +- spec/omniauth/strategies/twitter_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/omniauth/strategies/twitter.rb b/lib/omniauth/strategies/twitter.rb index 0d14f9f4..d3d41477 100644 --- a/lib/omniauth/strategies/twitter.rb +++ b/lib/omniauth/strategies/twitter.rb @@ -72,7 +72,7 @@ def image_url when 'original' original_url.sub('_normal', '') when '400x400' - original_url.sub('400x400', '400x400') + original_url.sub('normal', '400x400') else original_url end diff --git a/spec/omniauth/strategies/twitter_spec.rb b/spec/omniauth/strategies/twitter_spec.rb index ce918daf..2b3ae262 100644 --- a/spec/omniauth/strategies/twitter_spec.rb +++ b/spec/omniauth/strategies/twitter_spec.rb @@ -47,7 +47,7 @@ it 'should return secure image with size specified' do @options = { :secure_image_url => 'true', :image_size => '400x400' } allow(subject).to receive(:raw_info).and_return( - { 'profile_image_url_https' => 'https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_400x400.png' } + { 'profile_image_url_https' => 'https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_normal.png' } ) expect(subject.info[:image]).to eq('https://twimg0-a.akamaihd.net/sticky/default_profile_images/default_profile_0_400x400.png') end