Add support for Edge on non-Windows OS #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggythehamster
requested changes
Feb 4, 2021
| it "should return 'Windows 10' as its os" do | ||
| expect(@useragent.os).to eq("Windows 10") | ||
| end | ||
| end | ||
|
|
||
| describe "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36 Edg/88.0.705.56" do |
There was a problem hiding this comment.
Can you add a spec for the Android and ChromeOS user agents as well?
There was a problem hiding this comment.
I've done Android and iOS - I didn't think Edge was available for ChromeOS, would have to do a little more hunting for a suitable user-agent string.
There was a problem hiding this comment.
As far as I can tell, installing Edge on ChromeOS would mean installing the Android app, so I think the Android cases should suffice!
ziggythehamster
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge is now available on Mac, but "useragent" currently reports it as Windows. This PR adds support for OSes other than Windows.